gavinchou commented on code in PR #36786:
URL: https://github.com/apache/doris/pull/36786#discussion_r1666979122
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -1773,25 +1786,34 @@ public void addPartition(Database db, String tableName,
AddPartitionClause addPa
PartitionPersistInfo info = null;
if (partitionInfo.getType() == PartitionType.RANGE) {
info = new PartitionPersistInfo(db.getId(),
olapTable.getId(), partition,
- partitionInfo.getItem(partitionId).getItems(),
ListPartitionItem.DUMMY_ITEM, dataProperty,
- partitionInfo.getReplicaAllocation(partitionId),
partitionInfo.getIsInMemory(partitionId),
- isTempPartition,
partitionInfo.getIsMutable(partitionId));
+ partitionInfo.getItem(partitionId).getItems(),
ListPartitionItem.DUMMY_ITEM, dataProperty,
+ partitionInfo.getReplicaAllocation(partitionId),
partitionInfo.getIsInMemory(partitionId),
+ isTempPartition,
partitionInfo.getIsMutable(partitionId));
} else if (partitionInfo.getType() == PartitionType.LIST) {
info = new PartitionPersistInfo(db.getId(),
olapTable.getId(), partition,
- RangePartitionItem.DUMMY_RANGE,
partitionInfo.getItem(partitionId), dataProperty,
- partitionInfo.getReplicaAllocation(partitionId),
partitionInfo.getIsInMemory(partitionId),
- isTempPartition,
partitionInfo.getIsMutable(partitionId));
+ RangePartitionItem.DUMMY_RANGE,
partitionInfo.getItem(partitionId), dataProperty,
+ partitionInfo.getReplicaAllocation(partitionId),
partitionInfo.getIsInMemory(partitionId),
+ isTempPartition,
partitionInfo.getIsMutable(partitionId));
} else {
info = new PartitionPersistInfo(db.getId(),
olapTable.getId(), partition,
- RangePartitionItem.DUMMY_RANGE,
ListPartitionItem.DUMMY_ITEM, dataProperty,
- partitionInfo.getReplicaAllocation(partitionId),
partitionInfo.getIsInMemory(partitionId),
- isTempPartition,
partitionInfo.getIsMutable(partitionId));
+ RangePartitionItem.DUMMY_RANGE,
ListPartitionItem.DUMMY_ITEM, dataProperty,
+ partitionInfo.getReplicaAllocation(partitionId),
partitionInfo.getIsInMemory(partitionId),
+ isTempPartition,
partitionInfo.getIsMutable(partitionId));
}
- afterCreatePartitions(db.getId(), olapTable.getId(),
partitionIds, indexIds, false);
- Env.getCurrentEnv().getEditLog().logAddPartition(info);
-
- LOG.info("succeed in creating partition[{}], temp: {}",
partitionId, isTempPartition);
+ if (!isCreateTable) {
+ afterCreatePartitions(db.getId(), olapTable.getId(),
partitionIds, indexIds, isCreateTable);
+ }
+ if (writeEditLog) {
+ Env.getCurrentEnv().getEditLog().logAddPartition(info);
+ LOG.info("succeed in creating partition[{}], temp: {}",
partitionId, isTempPartition);
+ } else {
+ LOG.info("postpone creating partition[{}], temp: {}",
partitionId, isTempPartition);
+ }
+ if (!isCreateTable) {
+ checkCreatePartitions(db.getId(), olapTable.getId(),
partitionIds, indexIds);
Review Comment:
We have to check before writing edit log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
