xiaokang commented on code in PR #37429:
URL: https://github.com/apache/doris/pull/37429#discussion_r1667935223
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -2387,14 +2388,16 @@ Status
SegmentIterator::_next_batch_internal(vectorized::Block* block) {
}
}
}
- RETURN_IF_ERROR(_init_current_block(block, _current_return_columns));
- _converted_column_ids.assign(_schema->columns().size(), 0);
- _current_batch_rows_read = 0;
uint32_t nrows_read_limit = _opts.block_row_max;
if (_can_opt_topn_reads()) {
nrows_read_limit = std::min(static_cast<uint32_t>(_opts.topn_limit),
nrows_read_limit);
}
+
+ RETURN_IF_ERROR(_init_current_block(block, _current_return_columns));
Review Comment:
nrows_read_limit is not passed to _init_current_block()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
