wangbo commented on a change in pull request #8318:
URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r820052282
##########
File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp
##########
@@ -240,6 +241,16 @@ void BinaryDictPageDecoder::set_dict_decoder(PageDecoder*
dict_decoder, StringRe
Status BinaryDictPageDecoder::next_batch(size_t* n,
vectorized::MutableColumnPtr &dst) {
if (_encoding_type == PLAIN_ENCODING) {
+ auto* col_ptr = dst.get();
+ if (dst->is_nullable()) {
+ auto nullable_col =
reinterpret_cast<vectorized::ColumnNullable*>(dst.get());
+ col_ptr = nullable_col->get_nested_column_ptr().get();
+ }
Review comment:
I think it's a good idea to exposing ColumnDictionary to PageDecoder.
You should deal everything inside the ColumnDictionary.
Such as add a Method for ```IColumn``` named
```convertToCommonColumnIfNecessary```, or some other better way.
Of course, you can add a ```todo``` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
