This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 777c9a4 [typo](comment) Translate the code comments of gensrc (#8308)
777c9a4 is described below
commit 777c9a4060f50f0cb276de4668da711ec7eb0b4c
Author: Xin Liao <[email protected]>
AuthorDate: Sat Mar 5 14:39:16 2022 +0800
[typo](comment) Translate the code comments of gensrc (#8308)
---
gensrc/proto/column_data_file.proto | 4 ++--
gensrc/proto/olap_file.proto | 14 +++++++++-----
gensrc/thrift/PaloExternalDataSourceService.thrift | 2 +-
3 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/gensrc/proto/column_data_file.proto
b/gensrc/proto/column_data_file.proto
index 8bffbcc..b8bd158 100644
--- a/gensrc/proto/column_data_file.proto
+++ b/gensrc/proto/column_data_file.proto
@@ -51,9 +51,9 @@ message ColumnDataHeaderMessage {
required string magic_string = 1 [default = "COLUMN DATA"];
required uint32 version = 2 [default = 1];
required uint64 number_of_rows = 4;
- // 列Schema
+ // column schema
repeated ColumnMessage column = 5;
- // 每一列的统计信息
+ // statistics for each column
required uint64 index_length = 7;
required uint64 data_length = 8;
required CompressKind compress_kind = 9 [default = COMPRESS_LZO];
diff --git a/gensrc/proto/olap_file.proto b/gensrc/proto/olap_file.proto
index 5f3b226..026a99e 100644
--- a/gensrc/proto/olap_file.proto
+++ b/gensrc/proto/olap_file.proto
@@ -31,14 +31,18 @@ message ZoneMap {
}
enum RowsetTypePB {
- ALPHA_ROWSET = 0; // doris原有的列存格式
- BETA_ROWSET = 1; // 新列存
+ ALPHA_ROWSET = 0; // doris original column storage format
+ BETA_ROWSET = 1; // new column storage format
}
enum RowsetStatePB {
- PREPARED = 0; // 表示正在写入Rowset
- COMMITTED = 1; // 表示rowset 写入完成，但是用户还不可见；这个状态下的rowset，BE不能自行判断是否删除，必须由FE的指令
- VISIBLE = 2; // 表示rowset 已经对用户可见
+ // Rowset is being written
+ PREPARED = 0;
+ // Rowset writting is completed, but the user is not yet visible
+ // For rowset in this state, BE cannot determine whether to delete it by
itself, it must be instructed by FE
+ COMMITTED = 1;
+ // Rowset is already visible to the user
+ VISIBLE = 2;
}
// indicate whether date between segments of a rowset is overlappinng
diff --git a/gensrc/thrift/PaloExternalDataSourceService.thrift
b/gensrc/thrift/PaloExternalDataSourceService.thrift
index 32fe2b1..c4cce76 100644
--- a/gensrc/thrift/PaloExternalDataSourceService.thrift
+++ b/gensrc/thrift/PaloExternalDataSourceService.thrift
@@ -235,7 +235,7 @@ struct TExtCloseResult {
1: required Status.TStatus status
}
-// 这个data source可以认为是palo统一的外部data source的入口
+// This data source can be considered as the entry of palo's unified external
data source
service TExtDataSourceService {
// 1. palo be call this api to send index, type, shard id to es
// 2. es will open a search context and prepare data, will return a
context id
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
