platoneko commented on code in PR #37468:
URL: https://github.com/apache/doris/pull/37468#discussion_r1668316301
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -2468,28 +2447,17 @@ int InstanceRecycler::recycle_expired_stage_objects() {
LOG(WARNING) << "invalid idx: " << idx << ", id: " <<
stage.obj_info().id();
continue;
}
- auto& old_obj = instance_info_.obj_info()[idx - 1];
- S3Conf s3_conf;
- s3_conf.ak = old_obj.ak();
- s3_conf.sk = old_obj.sk();
- if (old_obj.has_encryption_info()) {
- AkSkPair plain_ak_sk_pair;
- int ret1 = decrypt_ak_sk_helper(old_obj.ak(), old_obj.sk(),
old_obj.encryption_info(),
- &plain_ak_sk_pair);
- if (ret1 != 0) {
- LOG(WARNING) << "fail to decrypt ak sk "
- << "obj_info:" << proto_to_json(old_obj);
- } else {
- s3_conf.ak = std::move(plain_ak_sk_pair.first);
- s3_conf.sk = std::move(plain_ak_sk_pair.second);
- }
+
+ const auto& old_obj = instance_info_.obj_info()[idx - 1];
+ auto s3_conf = S3Conf::from_obj_store_info(old_obj);
+ if (!s3_conf) {
+ LOG(WARNING) << "failed to init accessor";
Review Comment:
Obj info has been printed in `from_obj_store_info `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
