morrySnow commented on code in PR #37361:
URL: https://github.com/apache/doris/pull/37361#discussion_r1668321261
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java:
##########
@@ -300,12 +301,42 @@ public static boolean
couldColocateJoin(DistributionSpecHash leftHashSpec, Distr
boolean noNeedCheckColocateGroup = hitSameIndex &&
(leftTablePartitions.equals(rightTablePartitions))
&& (leftTablePartitions.size() <= 1);
ColocateTableIndex colocateIndex = Env.getCurrentColocateIndex();
- if (noNeedCheckColocateGroup
- || (colocateIndex.isSameGroup(leftTableId, rightTableId)
- &&
!colocateIndex.isGroupUnstable(colocateIndex.getGroup(leftTableId)))) {
+ if (noNeedCheckColocateGroup) {
return true;
}
- return false;
+ if (!colocateIndex.isSameGroup(leftTableId, rightTableId)
+ ||
colocateIndex.isGroupUnstable(colocateIndex.getGroup(leftTableId))) {
+ return false;
+ }
+
+ Set<Integer> equalIndices = new HashSet<>();
+ for (Expression expr : conjuncts) {
+ // only simple equal predicate can use colocate join
+ if (!(expr instanceof EqualPredicate)) {
+ return false;
+ }
+ Expression leftChild = ((EqualPredicate) expr).left();
+ Expression rightChild = ((EqualPredicate) expr).right();
Review Comment:
not always left for left child, right for right child
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
