HappenLee commented on code in PR #37330:
URL: https://github.com/apache/doris/pull/37330#discussion_r1668474056
##########
be/src/vec/aggregate_functions/aggregate_function_stddev.cpp:
##########
@@ -102,14 +116,22 @@ void
register_aggregate_function_stddev_variance_pop(AggregateFunctionSimpleFact
factory.register_alias("stddev", "stddev_pop");
}
+void
register_aggregate_function_stddev_variance_samp_old(AggregateFunctionSimpleFactory&
factory) {
+ factory.register_alternative_function(
+ "variance_samp",
create_aggregate_function_variance_samp_older<false, false>);
+ factory.register_alternative_function(
+ "variance_samp",
create_aggregate_function_variance_samp_older<false, true>, true);
+ factory.register_alias("variance_samp", "var_samp");
+ factory.register_alternative_function("stddev_samp",
+
create_aggregate_function_stddev_samp_older<true, false>);
+ factory.register_alternative_function(
+ "stddev_samp", create_aggregate_function_stddev_samp_older<true,
true>, true);
+}
+
void
register_aggregate_function_stddev_variance_samp(AggregateFunctionSimpleFactory&
factory) {
- factory.register_function("variance_samp",
- create_aggregate_function_variance_samp<false,
false>);
- factory.register_function("variance_samp",
create_aggregate_function_variance_samp<false, true>,
- true);
+ factory.register_function_both("variance_samp",
create_aggregate_function_variance_samp);
factory.register_alias("variance_samp", "var_samp");
Review Comment:
here register will there be conflicts and 124 lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
