freemandealer commented on code in PR #37312:
URL: https://github.com/apache/doris/pull/37312#discussion_r1669981670
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -796,6 +818,70 @@ bool BlockFileCache::try_reserve_for_ttl(size_t size,
std::lock_guard<std::mutex
return true;
}
+bool BlockFileCache::try_reserve_for_ttl(size_t size,
std::lock_guard<std::mutex>& cache_lock) {
+ if (try_reserve_for_ttl_without_lru(size, cache_lock)) {
Review Comment:
cannot see the improvement of code correctness and readability of such change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
