xiaokang commented on code in PR #37564:
URL: https://github.com/apache/doris/pull/37564#discussion_r1672384156


##########
be/src/olap/compaction.cpp:
##########
@@ -642,6 +642,9 @@ Status Compaction::do_inverted_index_compaction() {
     // format: rowsetId_segmentId
     std::vector<std::unique_ptr<InvertedIndexFileWriter>> 
inverted_index_file_writers(
             dest_segment_num);
+
+    // Some columns have already been indexed
+    std::vector<int64_t> compacted_idx_file_size(dest_segment_num, 0);

Review Comment:
   It is prone to errors to using index of vector to record size. I suggest you 
use a map with index file path as key.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to