EmmyMiao87 commented on a change in pull request #8390: URL: https://github.com/apache/incubator-doris/pull/8390#discussion_r821360252
########## File path: fe/fe-core/src/main/java/org/apache/doris/common/util/URI.java ########## @@ -0,0 +1,206 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.common.util; + +import org.apache.doris.common.AnalysisException; + +import org.apache.commons.lang.StringUtils; +import org.apache.parquet.Strings; + +import java.util.TreeMap; + +public class URI { + private static final String SCHEME_DELIM = "://"; + private static final String AUTH_DELIM = "@"; + private static final String PATH_DELIM = "/"; + private static final String QUERY_DELIM = "\\?"; + private static final String FRAGMENT_DELIM = "#"; + private static final String PASS_DELIM = ":"; + private static final String PORT_DELIM = ":"; + private static final String QUERY_ITEM_DELIM = "&"; + private static final String QUERY_KV_DELIM = "="; + + private final String location; + private String scheme; + private String authority; + private String host; + private int port; + private String userInfo; + private String userName; + private String passWord; + private String path; Review comment: ```suggestion private String path = ""; ``` ########## File path: fe/fe-core/src/main/java/org/apache/doris/common/util/URI.java ########## @@ -0,0 +1,206 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.common.util; + +import org.apache.doris.common.AnalysisException; + +import org.apache.commons.lang.StringUtils; +import org.apache.parquet.Strings; + +import java.util.TreeMap; + +public class URI { + private static final String SCHEME_DELIM = "://"; + private static final String AUTH_DELIM = "@"; + private static final String PATH_DELIM = "/"; + private static final String QUERY_DELIM = "\\?"; + private static final String FRAGMENT_DELIM = "#"; + private static final String PASS_DELIM = ":"; + private static final String PORT_DELIM = ":"; + private static final String QUERY_ITEM_DELIM = "&"; + private static final String QUERY_KV_DELIM = "="; + + private final String location; + private String scheme; + private String authority; + private String host; + private int port; Review comment: ```suggestion private int port = -1; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
