morningman commented on a change in pull request #8395:
URL: https://github.com/apache/incubator-doris/pull/8395#discussion_r821594894
##########
File path: be/src/vec/exec/volap_scan_node.cpp
##########
@@ -221,7 +221,14 @@ void VOlapScanNode::scanner_thread(VOlapScanner* scanner) {
std::lock_guard<std::mutex> l(_free_blocks_lock);
_free_blocks.emplace_back(block);
} else {
- blocks.push_back(block);
+ if (!blocks.empty() && blocks.back()->rows() + block->rows() <=
_runtime_state->batch_size()) {
Review comment:
Do we need a threshold? For example, if the full block size is 1024, but
each coming block size is 1023, than we have to merge block everytime, and
there is even a `mutex` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
