cambyzju commented on a change in pull request #8217:
URL: https://github.com/apache/incubator-doris/pull/8217#discussion_r821616912
##########
File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp
##########
@@ -723,14 +723,8 @@ void SegmentIterator::_init_current_block(
for (size_t i = 0; i < _schema.num_column_ids(); i++) {
auto cid = _schema.column_id(i);
auto column_desc = _schema.column(cid);
- auto data_type = Schema::get_data_type_ptr(column_desc->type());
- if (column_desc->is_nullable()) {
Review comment:
Schema::get_data_type_ptr will consider is_nullable, and will create
DataTypeNullable if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
