yiguolei commented on code in PR #37912:
URL: https://github.com/apache/doris/pull/37912#discussion_r1679090644
##########
regression-test/suites/query_p0/sql_functions/string_functions/test_string_function.groovy:
##########
@@ -228,6 +228,9 @@ suite("test_string_function", "arrow_flight_sql") {
qt_sql "select substring('abcdef',3,-1);"
qt_sql "select substring('abcdef',-3,-1);"
qt_sql "select substring('abcdef',10,1);"
+ qt_sql "select substring('中文测试',5);"
+ qt_sql "select substring('中文测试',4);"
+ qt_sql "select substring('中文测试',2,2);"
Review Comment:
add test for negative parameters and Chinese chars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
