yiguolei commented on a change in pull request #8423:
URL: https://github.com/apache/incubator-doris/pull/8423#discussion_r824351080



##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java
##########
@@ -240,7 +241,13 @@ private void publishVersion() throws UserException {
                     // one transaction exception should not affect other 
transaction
                     
globalTransactionMgr.finishTransaction(transactionState.getDbId(), 
transactionState.getTransactionId(), publishErrorReplicaIds);
                 } catch (Exception e) {
-                    LOG.warn("error happends when finish transaction {} ", 
transactionState.getTransactionId(), e);
+                    if (e instanceof MetaNotFoundException) {
+                        
globalTransactionMgr.abortTransaction(transactionState.getDbId(), 
transactionState.getTransactionId(), e.getMessage(),

Review comment:
       Do not need abort txn here? 
   If the database is force dropped, we could not get db related txn manager 
and will skip the txn in next loop.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to