wangbo commented on a change in pull request #8399:
URL: https://github.com/apache/incubator-doris/pull/8399#discussion_r824398096



##########
File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp
##########
@@ -76,6 +85,27 @@ class SegmentIterator::BitmapRangeIterator {
         return true;
     }
 
+    bool get_next_range_without_bitmap_index(uint32_t max_range_size, 
uint32_t* from, uint32_t* to) {
+        if (_curr_pos == _max_value) {
+            return false;
+        }
+        if (_curr_pos + max_range_size <= _max_value) {

Review comment:
       ```_eof``` is used to confirm whether reachs the end of 
```roaring_read_uint32_iterator```.
   If you don't use ```roaring_read_uint32_iterator```, then ```_eof``` is 
useless.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to