morningman commented on a change in pull request #8439:
URL: https://github.com/apache/incubator-doris/pull/8439#discussion_r824750657
##########
File path: be/src/exec/tablet_sink.h
##########
@@ -165,6 +165,7 @@ class NodeChannel {
Status add_row(Tuple* tuple, int64_t tablet_id);
+ // [[deprecated]]
Review comment:
This method is not deprecated. The previous comment is wrong.
##########
File path: be/src/agent/task_worker_pool.h
##########
@@ -96,16 +92,16 @@ class TaskWorkerPool {
return "REALTIME_PUSH";
case PUBLISH_VERSION:
return "PUBLISH_VERSION";
- case CLEAR_ALTER_TASK:
- return "CLEAR_ALTER_TASK";
+ // case CLEAR_ALTER_TASK:
Review comment:
remove it.
##########
File path: be/src/agent/task_worker_pool.h
##########
@@ -51,12 +51,12 @@ class TaskWorkerPool {
REALTIME_PUSH,
PUBLISH_VERSION,
// Deprecated
- CLEAR_ALTER_TASK,
+ CLEAR_ALTER_TASK [[deprecated]],
Review comment:
Just remove it?
##########
File path: be/src/exec/tablet_sink.h
##########
@@ -291,16 +292,18 @@ class IndexChannel {
Status init(RuntimeState* state, const std::vector<TTabletWithPartition>&
tablets);
void add_row(Tuple* tuple, int64_t tablet_id);
-
+ // [[deprecated]]
Review comment:
This method is not deprecated. The previous comment is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
