morningman commented on pull request #8451: URL: https://github.com/apache/incubator-doris/pull/8451#issuecomment-1065287730
LGTM, but there are 2 more things: 1. It is better to provide some data to illustrate the memory usage before and after the modification in order to give more information to the reviewer. 2. Also need to modify the `src/vec/exec/volap_scan_node.cpp` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
