morningman commented on a change in pull request #8387:
URL: https://github.com/apache/incubator-doris/pull/8387#discussion_r825648821
##########
File path: be/src/olap/tablet.cpp
##########
@@ -579,8 +579,8 @@ OLAPStatus Tablet::capture_consistent_versions(const
Version& spec_version,
}
OLAPStatus Tablet::check_version_integrity(const Version& version, bool quiet)
{
- ReadLock rdlock(&_meta_lock);
- return capture_consistent_versions(version, nullptr, quiet);
+ ReadLock rdlock(_meta_lock);
+ return capture_consistent_versions(version, nullptr);
Review comment:
why remove quiet
##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -783,7 +781,7 @@ OLAPStatus TabletManager::load_tablet_from_meta(DataDir*
data_dir, TTabletId tab
RETURN_NOT_OK_LOG(tablet->init(),
strings::Substitute("tablet init failed. tablet=$0",
tablet->full_name()));
- WriteLock wlock(_get_tablets_shard_lock(tablet_id));
+ WriteLock wrdlock(_get_tablets_shard_lock(tablet_id));
Review comment:
wrdlock? the name is strange.
##########
File path: be/src/olap/tablet.cpp
##########
@@ -839,7 +839,7 @@ void
Tablet::_max_continuous_version_from_beginning_unlocked(Version* version, V
}
void Tablet::calculate_cumulative_point() {
- WriteLock wrlock(&_meta_lock);
+ ReadLock wrlock(_meta_lock);
Review comment:
Why readlock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
