github-actions[bot] commented on code in PR #38143:
URL: https://github.com/apache/doris/pull/38143#discussion_r1684069735
##########
be/src/service/internal_service.cpp:
##########
@@ -1044,11 +1044,11 @@ struct AsyncRPCContext {
brpc::CallId cid;
};
-void
PInternalServiceImpl::fetch_remote_tablet_schema(google::protobuf::RpcController*
controller,
- const
PFetchRemoteSchemaRequest* request,
-
PFetchRemoteSchemaResponse* response,
-
google::protobuf::Closure* done) {
- bool ret = _heavy_work_pool.try_offer([this, request, response, done]() {
+void
PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcController*
controller,
Review Comment:
warning: function 'fetch_remote_tablet_schema' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
void
PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcController*
controller,
^
```
<details>
<summary>Additional context</summary>
**be/src/service/internal_service.cpp:1046:** 96 lines including whitespace
and comments (threshold 80)
```cpp
void
PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcController*
controller,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
