caiconghui commented on a change in pull request #8481:
URL: https://github.com/apache/incubator-doris/pull/8481#discussion_r826722725



##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/catalog/TabletInvertedIndex.java
##########
@@ -212,20 +212,8 @@ public void tabletReport(long backendId, Map<Long, 
TTablet> backendTablets,
                                                     + "clear it from backend 
[{}]", transactionId, backendId);
                                         } else if 
(transactionState.getTransactionStatus() == TransactionStatus.VISIBLE) {
                                             TableCommitInfo tableCommitInfo = 
transactionState.getTableCommitInfo(tabletMeta.getTableId());
-                                            PartitionCommitInfo 
partitionCommitInfo = tableCommitInfo.getPartitionCommitInfo(partitionId);
-                                            if (partitionCommitInfo == null) {
-                                                /*
-                                                 * This may happen as follows:
-                                                 * 1. txn is committed on BE, 
and report commit info to FE
-                                                 * 2. FE received report and 
begin to assemble partitionCommitInfos.
-                                                 * 3. At the same time, some 
of partitions have been dropped, so partitionCommitInfos does not contain these 
partitions.
-                                                 * 4. So we will not able to 
get partitionCommitInfo here.
-                                                 *
-                                                 * Just print a log to observe
-                                                 */
-                                                LOG.info("failed to find 
partition commit info. table: {}, partition: {}, tablet: {}, txn id: {}",
-                                                        
tabletMeta.getTableId(), partitionId, tabletId, 
transactionState.getTransactionId());
-                                            } else {
+                                            PartitionCommitInfo 
partitionCommitInfo = tableCommitInfo == null ? null : 
tableCommitInfo.getPartitionCommitInfo(partitionId);
+                                            if (partitionCommitInfo != null) {

Review comment:
       I think print log for normal situation is so necessary if we could not 
get any useful information




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to