HappenLee commented on a change in pull request #8489:
URL: https://github.com/apache/incubator-doris/pull/8489#discussion_r826785550
##########
File path: be/src/exprs/bitmap_function.cpp
##########
@@ -156,6 +156,11 @@ void read_from(const char** src, StringValue* result) {
} // namespace detail
static StringVal serialize(FunctionContext* ctx, BitmapValue* value) {
Review comment:
this code is dangerous, use a pointer to reference of stack value. if
value == nullptr, should do value write and return in if {
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
