adonis0147 commented on a change in pull request #8494:
URL: https://github.com/apache/incubator-doris/pull/8494#discussion_r827817382
##########
File path: be/src/vec/columns/column_array.cpp
##########
@@ -311,7 +311,7 @@ void ColumnArray::insert_range_from(const IColumn & src,
size_t start, size_t le
cur_offsets.assign(src_offsets.begin(), src_offsets.begin() + length);
} else {
size_t old_size = cur_offsets.size();
- size_t prev_max_offset = old_size ? cur_offsets.back() : 0;
Review comment:
Yes, `-1` here is ok due to the `Offsets` (PaddedPODArray<Uint32>) is
always padded zero left here. If you refer to the method `offset_at` in class
`ColumnArray`, you will notice that the offset of the beginning element
(position 0) is at the position -1 in offsets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
