This is an automated email from the ASF dual-hosted git repository.
kirs pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ba5aa3112dd [Fix](JobManager)Release the lock immediately after
modifying job metadata to avoid holding the lock for an extended period.
(#38162)
ba5aa3112dd is described below
commit ba5aa3112dd08077089bb15fc24e569b7b47b4ce
Author: Calvin Kirs <[email protected]>
AuthorDate: Tue Jul 23 12:05:14 2024 +0800
[Fix](JobManager)Release the lock immediately after modifying job metadata
to avoid holding the lock for an extended period. (#38162)
## Proposed changes
When deleting a job in MV, a DB lock is held. However, due to the larger
lock granularity of the Job Manager, this may prevent obtaining the
lock. This issue arises because during the creation of a job,
immediately scheduled tasks need to perform their initial scheduling and
compensate for tasks within the time window. To alleviate this issue, we
are attempting to reduce the lock granularity.
<!--Describe your changes.-->
---
.../main/java/org/apache/doris/job/manager/JobManager.java | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/job/manager/JobManager.java
b/fe/fe-core/src/main/java/org/apache/doris/job/manager/JobManager.java
index d8a30a968a6..39646bab18f 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/job/manager/JobManager.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/job/manager/JobManager.java
@@ -111,12 +111,19 @@ public class JobManager<T extends AbstractJob<?, C>, C>
implements Writable {
throw new JobException("job id exist, jobId:" +
job.getJobId());
}
jobMap.put(job.getJobId(), job);
- //check its need to scheduler
- jobScheduler.scheduleOneJob(job);
job.logCreateOperation();
} finally {
writeUnlock();
}
+ try {
+ //check its need to scheduler
+ jobScheduler.scheduleOneJob(job);
+ } catch (Exception e) {
+ // if scheduler job error, we need to unregister job
+ log.warn(("first schedule job error,unregister job, jobName:" +
job.getJobName()), e);
+ unregisterJob(job.getJobId());
+ throw new JobException("register job error, jobName:" +
job.getJobName());
+ }
}
private void checkJobNameExist(String jobName) throws JobException {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
