gavinchou commented on code in PR #38239:
URL: https://github.com/apache/doris/pull/38239#discussion_r1687535686
##########
be/cmake/thirdparty.cmake:
##########
@@ -141,10 +141,12 @@ if (NOT OS_MACOSX)
add_thirdparty(aws-s2n LIBNAME "lib/libs2n.a")
endif()
-add_thirdparty(azure-core)
-add_thirdparty(azure-identity)
-add_thirdparty(azure-storage-blobs)
-add_thirdparty(azure-storage-common)
+if(USE_AZURE)
Review Comment:
WITH_AZURE ?
##########
be/src/util/s3_util.cpp:
##########
@@ -228,6 +233,10 @@ std::shared_ptr<io::ObjStorageClient>
S3ClientFactory::_create_azure_client(
auto containerClient =
std::make_shared<Azure::Storage::Blobs::BlobContainerClient>(uri, cred);
LOG_INFO("create one azure client with {}", s3_conf.to_string());
return
std::make_shared<io::AzureObjStorageClient>(std::move(containerClient));
+#else
+ LOG_FATAL("Your BE dosen't compile azure");
Review Comment:
"BE is not compiled with azure support, export WITH_AZURE=ON before building"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
