morningman commented on pull request #8476: URL: https://github.com/apache/incubator-doris/pull/8476#issuecomment-1069970553
> You'd better split changes into small parts. e.g. 1. implement new memory tracker by hooking new, delete but not enable; 2. enable new memory tracker by removing old usage; 3. handle null pointer for old fasion allocate 4. add memory tracker for untracked memory usage; This is indeed a worse way to submit a PR, but for this current PR, I would suggest leaving it as is for now to avoid some more uncontrollable factors when splitting the PR. We will gradually ask to split it as much as possible for subsequent PRs. But DSIP is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
