caiconghui commented on a change in pull request #8486:
URL: https://github.com/apache/incubator-doris/pull/8486#discussion_r828814233
##########
File path: be/src/olap/tablet_manager.h
##########
@@ -183,26 +176,17 @@ class TabletManager {
const Tablet* base_tablet,
TabletMetaSharedPtr* tablet_meta);
- void _add_tablet_to_partition(const Tablet& tablet);
+ void _add_tablet_to_partition(const TabletSharedPtr& tablet);
- void _remove_tablet_from_partition(const Tablet& tablet);
+ void _remove_tablet_from_partition(const TabletSharedPtr& tablet);
std::shared_mutex& _get_tablets_shard_lock(TTabletId tabletId);
private:
DISALLOW_COPY_AND_ASSIGN(TabletManager);
- // TODO(lingbin): should be TabletInstances?
- // should be removed after schema_hash be removed
- struct TableInstances {
- Mutex schema_change_lock;
- // The first element(i.e. tablet_arr[0]) is the base tablet. When we
add new tablet
- // to tablet_arr, we will sort all the elements in create-time
ascending order,
- // which will ensure the first one is base-tablet
- std::list<TabletSharedPtr> table_arr;
- };
// tablet_id -> TabletInstances
Review comment:
removet this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
