gavinchou commented on code in PR #37293:
URL: https://github.com/apache/doris/pull/37293#discussion_r1694302888
##########
be/src/cloud/cloud_base_compaction.cpp:
##########
@@ -97,6 +99,18 @@ Status CloudBaseCompaction::prepare_compact() {
} else if (resp.status().code() == cloud::TABLET_NOT_FOUND) {
// tablet not found
cloud_tablet()->clear_cache();
+ } else if (resp.status().code() ==
cloud::JOB_CHECK_ALTER_VERSION_FAIL) {
+
(dynamic_cast<CloudTablet*>(_tablet.get()))->set_alter_version(resp.alter_version());
Review Comment:
just static_cast if you dont check the cast result.
Add comment or add enough infomation in log why do we need to update alter
version here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
