taberylyang commented on a change in pull request #8393:
URL: https://github.com/apache/incubator-doris/pull/8393#discussion_r830069277
##########
File path: be/src/vec/exec/join/vhash_join_node.cpp
##########
@@ -160,7 +161,7 @@ struct ProcessHashTableProbe {
: _join_node(join_node),
_batch_size(batch_size),
_probe_rows(probe_rows),
- _build_blocks(join_node->_build_blocks),
+
_build_blocks(join_node->_shared_hash_table_ctx._shared_structure->_build_blocks),
Review comment:
you are right,so right join is prohibited in Fe.In the future, each
shared thread can occupy a bit on the hash table to record whether the current
row has been matched. If right join is used frequently, we can consider adding
this feature
##########
File path: be/src/vec/exec/join/vhash_join_node.cpp
##########
@@ -160,7 +161,7 @@ struct ProcessHashTableProbe {
: _join_node(join_node),
_batch_size(batch_size),
_probe_rows(probe_rows),
- _build_blocks(join_node->_build_blocks),
+
_build_blocks(join_node->_shared_hash_table_ctx._shared_structure->_build_blocks),
Review comment:
you are right,so right join for shared hash table is prohibited in Fe.In
the future, each shared thread can occupy a bit on the hash table to record
whether the current row has been matched. If right join is used frequently, we
can consider adding this feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
