morningman commented on a change in pull request #8516:
URL: https://github.com/apache/incubator-doris/pull/8516#discussion_r830623809
##########
File path: be/src/util/jni-util.h
##########
@@ -18,6 +18,7 @@
#ifndef DORIS_BE_SRC_UTIL_JNI_H
#define DORIS_BE_SRC_UTIL_JNI_H
Review comment:
use #pragma once
##########
File path: be/src/service/doris_main.cpp
##########
@@ -477,13 +477,13 @@ int main(int argc, char** argv) {
exit(1);
}
+#ifdef LIBJVM
// 6. init jni
status = doris::JniUtil::Init();
if (!status.ok()) {
- LOG(ERROR) << "Failed to initialize JNI: " << status.get_error_msg();
- doris::shutdown_logging();
- exit(1);
+ LOG(WARNING) << "Failed to initialize JNI: " << status.get_error_msg();
Review comment:
For starting up, if we failed to init JNI, I think we can exit the
process directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
