github-actions[bot] commented on code in PR #38494:
URL: https://github.com/apache/doris/pull/38494#discussion_r1695135246


##########
be/src/runtime/workload_group/workload_group_manager.cpp:
##########
@@ -153,86 +153,101 @@ struct WorkloadGroupMemInfo {
             std::list<std::shared_ptr<MemTrackerLimiter>>();
 };
 
-void WorkloadGroupMgr::refresh_wg_weighted_memory_ratio() {
+void WorkloadGroupMgr::refresh_wg_weighted_memory_limit() {

Review Comment:
   warning: function 'refresh_wg_weighted_memory_limit' exceeds recommended 
size/complexity thresholds [readability-function-size]
   ```cpp
   void WorkloadGroupMgr::refresh_wg_weighted_memory_limit() {
                          ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/runtime/workload_group/workload_group_manager.cpp:155:** 102 lines 
including whitespace and comments (threshold 80)
   ```cpp
   void WorkloadGroupMgr::refresh_wg_weighted_memory_limit() {
                          ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to