morningman commented on a change in pull request #8560:
URL: https://github.com/apache/incubator-doris/pull/8560#discussion_r831726039
##########
File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp
##########
@@ -638,6 +638,14 @@ void SegmentIterator::_vec_init_lazy_materialization() {
if (!_is_pred_column[cid]) {
_non_predicate_columns.push_back(cid);
is_non_predicate_column_exists = true;
+
+ // todo(wb) make a cost-based lazy-materialization
framework
+ // check non-pred column type to decide whether using
lazy-materialization
+ FieldType type = _schema.column(cid)->type();
+ if ((_is_all_column_basic_type == true) && (type ==
OLAP_FIELD_TYPE_HLL || type == OLAP_FIELD_TYPE_OBJECT
Review comment:
```suggestion
if (_is_all_column_basic_type && (type ==
OLAP_FIELD_TYPE_HLL || type == OLAP_FIELD_TYPE_OBJECT
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
