gavinchou commented on code in PR #37293:
URL: https://github.com/apache/doris/pull/37293#discussion_r1699319052


##########
fe/fe-core/src/main/java/org/apache/doris/alter/CloudRollupJobV2.java:
##########
@@ -124,6 +124,20 @@ protected void onCancel() {
             try {
                 ((CloudInternalCatalog) Env.getCurrentInternalCatalog())
                     .dropMaterializedIndex(tableId, rollupIndexList, false);
+                for (Map.Entry<Long, Map<Long, Long>> partitionEntry : 
partitionIdToBaseRollupTabletIdMap.entrySet()) {
+                    Long partitionId = partitionEntry.getKey();
+                    Map<Long, Long> rollupTabletIdToBaseTabletId = 
partitionEntry.getValue();
+                    for (Map.Entry<Long, Long> tabletEntry : 
rollupTabletIdToBaseTabletId.entrySet()) {
+                        Long rollupTabletId = tabletEntry.getKey();
+                        Long baseTabletId = tabletEntry.getValue();
+                        ((CloudInternalCatalog) 
Env.getCurrentInternalCatalog())
+                            .removeSchemaChangeJob(dbId, tableId, baseIndexId, 
rollupIndexId,
+                                    partitionId, baseTabletId, rollupTabletId);

Review Comment:
   try best to cancel sc job even there is a RPC error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to