hf200012 commented on a change in pull request #18:
URL:
https://github.com/apache/incubator-doris-flink-connector/pull/18#discussion_r825391855
##########
File path:
flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisDynamicTableFactory.java
##########
@@ -141,6 +141,12 @@
.booleanType()
.defaultValue(true)
.withDescription("whether to enable the delete function");
+ private static final ConfigOption<Long> SINK_BUFFER_FLUSH_MAX_BYTES =
ConfigOptions
+ .key("sink.batch.bytes")
+ .longType()
+ .defaultValue(DorisExecutionOptions.DEFAULT_MAX_BATCH_BYTES)
+ .withDescription("the flush max bytes (includes all append, upsert
and delete records), over this number" +
+ " in batch, will flush data. The default value is 10MB.");
Review comment:
10MB -> DorisExecutionOptions.DEFAULT_MAX_BATCH_BYTES
Is it better to use variable substitution here? If the user changes this
default value, the information displayed here will be incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
