xinyiZzz commented on a change in pull request #8605:
URL: https://github.com/apache/incubator-doris/pull/8605#discussion_r833050475
##########
File path: be/src/runtime/thread_mem_tracker_mgr.cpp
##########
@@ -70,12 +72,12 @@ void ThreadMemTrackerMgr::exceeded_cancel_task(const
std::string& cancel_details
void ThreadMemTrackerMgr::exceeded(int64_t mem_usage, Status st) {
auto rst = _mem_trackers[_tracker_id]->mem_limit_exceeded(
- nullptr, "In TCMalloc Hook, " +
_consume_err_call_back.action_type, mem_usage, st);
- if (_consume_err_call_back.call_back_func != nullptr) {
- _consume_err_call_back.call_back_func();
+ nullptr, "In TCMalloc Hook, " + _consume_err_cb.cancel_msg,
mem_usage, st);
Review comment:
why is this, adding two strings directly seems to be more concise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
