xzj7019 commented on code in PR #38393:
URL: https://github.com/apache/doris/pull/38393#discussion_r1703522251
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalWindow.java:
##########
@@ -171,61 +181,162 @@ public int hashCode() {
}
/**
- * pushPartitionLimitThroughWindow is used to push the partitionLimit
through the window
- * and generate the partitionTopN. If the window can not meet the
requirement,
- * it will return null. So when we use this function, we need check the
null in the outside.
+ * check and get valid window function and partition limit value
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
