HappenLee commented on a change in pull request #8572:
URL: https://github.com/apache/incubator-doris/pull/8572#discussion_r834002852
##########
File path: be/src/vec/aggregate_functions/aggregate_function_percentile_approx.h
##########
@@ -152,32 +151,57 @@ class AggregateFunctionPercentileApproxMerge : public
AggregateFunctionPercentil
}
};
+template <bool is_nullable>
class AggregateFunctionPercentileApproxTwoParams : public
AggregateFunctionPercentileApprox {
public:
AggregateFunctionPercentileApproxTwoParams(const DataTypes&
argument_types_)
: AggregateFunctionPercentileApprox(argument_types_) {}
void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
Arena*) const override {
- const auto& sources = static_cast<const
ColumnVector<Float64>&>(*columns[0]);
- const auto& quantile = static_cast<const
ColumnVector<Float64>&>(*columns[1]);
+ if constexpr (is_nullable) {
+ const auto* nullable_column =
check_and_get_column<ColumnNullable>(columns[0]);
+ const auto& sources =
+ static_cast<const
ColumnVector<Float64>&>(nullable_column->get_nested_column());
+ //requires second parameter must be a constant
+ const auto& quantile = static_cast<const
ColumnVector<Float64>&>(*columns[1]);
+ this->data(place).init();
+ this->data(place).add(sources.get_float64(row_num),
quantile.get_float64(row_num));
- this->data(place).init();
- this->data(place).add(sources.get_float64(row_num),
quantile.get_float64(row_num));
+ } else {
+ const auto& sources = static_cast<const
ColumnVector<Float64>&>(*columns[0]);
+ const auto& quantile = static_cast<const
ColumnVector<Float64>&>(*columns[1]);
+
+ this->data(place).init();
+ this->data(place).add(sources.get_float64(row_num),
quantile.get_float64(row_num));
+ }
}
};
+template <bool is_nullable>
class AggregateFunctionPercentileApproxThreeParams : public
AggregateFunctionPercentileApprox {
public:
AggregateFunctionPercentileApproxThreeParams(const DataTypes&
argument_types_)
: AggregateFunctionPercentileApprox(argument_types_) {}
void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
Arena*) const override {
- const auto& sources = static_cast<const
ColumnVector<Float64>&>(*columns[0]);
- const auto& quantile = static_cast<const
ColumnVector<Float64>&>(*columns[1]);
- const auto& compression = static_cast<const
ColumnVector<Float64>&>(*columns[2]);
+ if constexpr (is_nullable) {
+ const auto* nullable_column =
check_and_get_column<ColumnNullable>(columns[0]);
Review comment:
same to the up
##########
File path: be/src/vec/aggregate_functions/aggregate_function_percentile_approx.h
##########
@@ -152,32 +151,57 @@ class AggregateFunctionPercentileApproxMerge : public
AggregateFunctionPercentil
}
};
+template <bool is_nullable>
class AggregateFunctionPercentileApproxTwoParams : public
AggregateFunctionPercentileApprox {
public:
AggregateFunctionPercentileApproxTwoParams(const DataTypes&
argument_types_)
: AggregateFunctionPercentileApprox(argument_types_) {}
void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
Arena*) const override {
- const auto& sources = static_cast<const
ColumnVector<Float64>&>(*columns[0]);
- const auto& quantile = static_cast<const
ColumnVector<Float64>&>(*columns[1]);
+ if constexpr (is_nullable) {
+ const auto* nullable_column =
check_and_get_column<ColumnNullable>(columns[0]);
Review comment:
need check null in nullable column first！！！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
