whutpencil commented on a change in pull request #8603:
URL: https://github.com/apache/incubator-doris/pull/8603#discussion_r834977588
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
##########
@@ -157,7 +159,7 @@ public void analyze(boolean isOlap) throws
AnalysisException {
final ScalarType targetType = (ScalarType) typeDef.getType();
Review comment:
> default len of StringType is MAX_STRING_LENGTH, it seems your change
is the same as just remove codes between line 158 to line 163.
This is because I don't know where the length of string is set to 1, so I
directly specify the maximum value here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]