zbtzbtzbt commented on a change in pull request #8675:
URL: https://github.com/apache/incubator-doris/pull/8675#discussion_r835767244
##########
File path: be/src/runtime/descriptors.h
##########
@@ -58,12 +58,14 @@ class PSlotDescriptor;
struct NullIndicatorOffset {
int byte_offset;
uint8_t bit_mask; // to extract null indicator
- uint8_t bit_offset; // only used to serialize, from 1 to 8
+ int8_t bit_offset; // only used to serialize, from 1 to 8
Review comment:
I think we can add notes like `null value bit_offset = -1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
