HappenLee commented on a change in pull request #8660:
URL: https://github.com/apache/incubator-doris/pull/8660#discussion_r835789909
##########
File path: be/src/vec/aggregate_functions/aggregate_function_stddev.h
##########
@@ -200,13 +192,71 @@ struct PopData : Data {
}
};
+template <typename Data>
+struct StddevName : Data {
+ static const char* name() { return "stddev"; }
+};
+
+template <typename Data>
+struct VarianceName : Data {
+ static const char* name() { return "variance"; }
+};
+
+template <typename Data>
+struct VarianceSampName : Data {
+ static const char* name() { return "variance_samp"; }
+};
+
+template <typename Data>
+struct StddevSampName : Data {
+ static const char* name() { return "stddev_samp"; }
+};
+
+template <typename Data, bool is_nullable = false>
+class AggregateFunctionPop final
Review comment:
You should learn more abstract templates
`AggregateFunctionPop` and `AggregateFunctionSamp`
##########
File path: be/src/vec/aggregate_functions/aggregate_function_percentile_approx.h
##########
@@ -105,7 +105,7 @@ class AggregateFunctionPercentileApprox
String get_name() const override { return "percentile_approx"; }
- bool insert_to_null_default() const override { return false; }
+ //bool insert_to_null_default() const override { return false; }
Review comment:
delete the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
