yiguolei commented on code in PR #39066:
URL: https://github.com/apache/doris/pull/39066#discussion_r1708285017
##########
be/src/olap/txn_manager.cpp:
##########
@@ -747,8 +747,10 @@ void
TxnManager::force_rollback_tablet_related_txns(OlapMeta* meta, TTabletId ta
}
}
}
- static_cast<void>(
- RowsetMetaManager::remove_tablet_related_partial_update_info(meta,
tablet_id));
+ if (meta != nullptr) {
+ static_cast<void>(
+
RowsetMetaManager::remove_tablet_related_partial_update_info(meta, tablet_id));
+ }
Review Comment:
why cast the result as static void?
If you do not need check the result, I think you should modify the method to
return void.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
