github-actions[bot] commented on code in PR #39112:
URL: https://github.com/apache/doris/pull/39112#discussion_r1709158004
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -140,23 +141,16 @@ Status VMysqlResultWriter<is_binary_format>::_set_options(
}
template <bool is_binary_format>
-Status VMysqlResultWriter<is_binary_format>::write(Block& input_block) {
- SCOPED_TIMER(_append_row_batch_timer);
- Status status = Status::OK();
- if (UNLIKELY(input_block.rows() == 0)) {
- return status;
- }
-
- DCHECK(_output_vexpr_ctxs.empty() != true);
+bool VMysqlResultWriter<is_binary_format>::can_sink() {
+ return _sinker->can_sink();
+}
- // Exec vectorized expr here to speed up, block.rows() == 0 means expr exec
- // failed, just return the error status
- Block block;
-
RETURN_IF_ERROR(VExprContext::get_output_block_after_execute_exprs(_output_vexpr_ctxs,
-
input_block, &block));
+template <bool is_binary_format>
+Status VMysqlResultWriter<is_binary_format>::_write_one_block(Block& block) {
Review Comment:
warning: function '_write_one_block' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status VMysqlResultWriter<is_binary_format>::_write_one_block(Block& block) {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/sink/vmysql_result_writer.cpp:148:** 95 lines including
whitespace and comments (threshold 80)
```cpp
Status VMysqlResultWriter<is_binary_format>::_write_one_block(Block& block) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
