adonis0147 commented on a change in pull request #8691:
URL: https://github.com/apache/incubator-doris/pull/8691#discussion_r836050678
##########
File path: be/CMakeLists.txt
##########
@@ -152,9 +152,6 @@ set_target_properties(protoc PROPERTIES IMPORTED_LOCATION
${THIRDPARTY_DIR}/lib/
add_library(gtest STATIC IMPORTED)
set_target_properties(gtest PROPERTIES IMPORTED_LOCATION
${THIRDPARTY_DIR}/lib/libgtest.a)
-add_library(gtest_main STATIC IMPORTED)
-set_target_properties(gtest_main PROPERTIES IMPORTED_LOCATION
${THIRDPARTY_DIR}/lib/libgtest_main.a)
-
Review comment:
We can omit `main` function definition in test if we link gtest_main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
