pengxiangyu commented on a change in pull request #7529:
URL: https://github.com/apache/incubator-doris/pull/7529#discussion_r836079685



##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -1091,7 +1131,48 @@ void 
TabletManager::try_delete_unused_tablet_path(DataDir* data_dir, TTabletId t
     // TODO(ygl): may do other checks in the future
     if (Env::Default()->path_exists(schema_hash_path).ok()) {
         LOG(INFO) << "start to move tablet to trash. tablet_path = " << 
schema_hash_path;
-        OLAPStatus rm_st = move_to_trash(schema_hash_path, schema_hash_path);
+        FilePathDesc segment_desc(schema_hash_path);

Review comment:
       Every remote data has a local meta, When the local meta is deleted, 
remote data will be deleted too.
   If deleted by fe, when a migration operation is failed and did not notify 
fe, how can fe know it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to