xiaokang commented on code in PR #39104:
URL: https://github.com/apache/doris/pull/39104#discussion_r1709839928


##########
be/src/exec/es/es_scroll_parser.cpp:
##########
@@ -111,6 +111,17 @@ static const std::string INVALID_NULL_VALUE =
         }                                                                    \
     } while (false)
 
+#define RETURN_ERROR_IF_COL_IS_NOT_ARRAY(col, type)                          \
+    do {                                                                     \
+        if (!col.IsArray()) {                                                \

Review Comment:
   duplicate code with RETURN_ERROR_IF_COL_IS_ARRAY except '!' , so they can be 
combined into one with one more argument.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to