This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 9b9deb37dab [fix](fe) Fix calc cloud qps metric incorrect (#38874)
9b9deb37dab is described below
commit 9b9deb37dab10c2fb32bbabd280208c9abad8d46
Author: Lei Zhang <[email protected]>
AuthorDate: Fri Aug 9 12:36:17 2024 +0800
[fix](fe) Fix calc cloud qps metric incorrect (#38874)
* When calculating qps, we should use `HashMap.put` instead of
`HashMap.replace` to record last value
---
.../src/main/java/org/apache/doris/metric/MetricCalculator.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/metric/MetricCalculator.java
b/fe/fe-core/src/main/java/org/apache/doris/metric/MetricCalculator.java
index 44ba7dd7cea..f4beed94b0c 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/metric/MetricCalculator.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/metric/MetricCalculator.java
@@ -130,7 +130,7 @@ public class MetricCalculator extends TimerTask {
rps = Double.max(rps, 0);
MetricRepo.updateClusterRequestPerSecond(clusterId, rps,
metric.getLabels());
MetricRepo.DORIS_METRIC_REGISTER.addMetrics(metric);
- clusterLastRequestCounter.replace(clusterId,
metric.getValue());
+ clusterLastRequestCounter.put(clusterId, metric.getValue());
});
}
@@ -142,7 +142,7 @@ public class MetricCalculator extends TimerTask {
rps = Double.max(rps, 0);
MetricRepo.updateClusterQueryPerSecond(clusterId, rps,
metric.getLabels());
MetricRepo.DORIS_METRIC_REGISTER.addMetrics(metric);
- clusterLastQueryCounter.replace(clusterId, metric.getValue());
+ clusterLastQueryCounter.put(clusterId, metric.getValue());
});
}
@@ -154,7 +154,7 @@ public class MetricCalculator extends TimerTask {
rps = Double.max(rps, 0);
MetricRepo.updateClusterQueryErrRate(clusterId, rps,
metric.getLabels());
MetricRepo.DORIS_METRIC_REGISTER.addMetrics(metric);
- clusterLastQueryCounter.replace(clusterId, metric.getValue());
+ clusterLastQueryErrCounter.put(clusterId, metric.getValue());
});
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
