This is an automated email from the ASF dual-hosted git repository.
liaoxin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new cd0a8eca680 [fix](move-memtable) fix bvar
g_load_stream_file_writer_cnt (#39075)
cd0a8eca680 is described below
commit cd0a8eca680df9c1f9c8adf7e62327e34e4e7403
Author: Kaijie Chen <[email protected]>
AuthorDate: Fri Aug 9 14:31:45 2024 +0800
[fix](move-memtable) fix bvar g_load_stream_file_writer_cnt (#39075)
Previously the bvar `g_load_stream_file_writer_cnt` is not accurate when
error happens.
Some `FileWriters` are not supposed to be closed manually.
All `FileWriter` in `LoadStreamWriter` is managed by `std::unique_ptr`.
A `FileWriter` should be able to close itself and cleanup storage state
on its deconstructor.
This PR changes the bvar `g_load_stream_file_writer_cnt` to track
deconstruction of `FileWriter`,
instead of tracking `FileWriter` close.
---
be/src/runtime/load_stream_writer.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/be/src/runtime/load_stream_writer.cpp
b/be/src/runtime/load_stream_writer.cpp
index d501de3d53f..ca78311b8ea 100644
--- a/be/src/runtime/load_stream_writer.cpp
+++ b/be/src/runtime/load_stream_writer.cpp
@@ -84,6 +84,8 @@ LoadStreamWriter::LoadStreamWriter(WriteRequest* context,
RuntimeProfile* profil
}
LoadStreamWriter::~LoadStreamWriter() {
+ g_load_stream_file_writer_cnt << -_segment_file_writers.size();
+ g_load_stream_file_writer_cnt << -_inverted_file_writers.size();
g_load_stream_writer_cnt << -1;
}
@@ -164,7 +166,6 @@ Status LoadStreamWriter::close_writer(uint32_t segid,
FileType file_type) {
_is_canceled = true;
return st;
}
- g_load_stream_file_writer_cnt << -1;
LOG(INFO) << "file " << segid << " path " << file_writer->path().native()
<< "closed, written "
<< file_writer->bytes_appended() << " bytes"
<< ", file type is " << file_type;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
