wangbo commented on a change in pull request #8627:
URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836305968
##########
File path: be/src/olap/comparison_predicate.cpp
##########
@@ -159,60 +159,54 @@
COMPARISON_PRED_COLUMN_BLOCK_EVALUATE(GreaterEqualPredicate, >=)
.get_data();
\
auto& nested_col = nullable_col->get_nested_column();
\
if (nested_col.is_column_dictionary()) {
\
- if constexpr (std::is_same_v<type, StringValue>) {
\
+ if constexpr (std::is_same_v<T, StringValue>) {
\
Review comment:
Is this ```std::is_same_v<T, StringValue>``` necessary?
If a column is ColumnDict, then its TYPE in predicate can only be
StringValue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
