morrySnow commented on code in PR #38479:
URL: https://github.com/apache/doris/pull/38479#discussion_r1713545966
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ExtractSingleTableExpressionFromDisjunction.java:
##########
@@ -50,24 +52,44 @@
* 3. In old optimizer, there is `InferFilterRule` generates redundancy
expressions. Its Nereid counterpart also need
* `RemoveRedundantExpression`.
* <p>
- * TODO: This rule just match filter, but it could be applied to inner/cross
join condition.
*/
-public class ExtractSingleTableExpressionFromDisjunction extends
OneRewriteRuleFactory {
+public class ExtractSingleTableExpressionFromDisjunction implements
RewriteRuleFactory {
+ private static final ImmutableSet<JoinType> ALLOW_JOIN_TYPE =
ImmutableSet.of(JoinType.INNER_JOIN,
+ JoinType.LEFT_OUTER_JOIN, JoinType.RIGHT_OUTER_JOIN,
JoinType.LEFT_SEMI_JOIN, JoinType.RIGHT_SEMI_JOIN,
Review Comment:
why not support full outer join?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
