EmmyMiao87 commented on a change in pull request #8722:
URL: https://github.com/apache/incubator-doris/pull/8722#discussion_r837226563
##########
File path: be/src/vec/exec/join/vhash_join_node.h
##########
@@ -232,6 +232,10 @@ class HashJoinNode : public ::doris::ExecNode {
std::vector<int> _build_block_rows;
std::shared_ptr<MemTracker> _hash_table_mem_tracker;
+
+ std::vector<SlotId> _output_slot_ids;
Review comment:
maybe '_hash_output_slot_ids' is better ?
##########
File path: be/src/vec/exec/join/vhash_join_node.cpp
##########
@@ -706,6 +730,19 @@ Status HashJoinNode::init(const TPlanNode& tnode,
RuntimeState* state) {
filter_desc, state->query_options()));
}
+ // init left/right output slots flags
Review comment:
Could you please add a example to illustrate the value of the
'_left_output_slot_flags' and '_left_output_slot_flags'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
