HappenLee commented on a change in pull request #8678:
URL: https://github.com/apache/incubator-doris/pull/8678#discussion_r839503079



##########
File path: be/src/vec/functions/function_java_udf.h
##########
@@ -76,27 +76,37 @@ class JavaFunctionCall : public IFunctionBase {
     jmethodID executor_evaluate_id_;
     jmethodID executor_close_id_;
 
+    struct IntermediateState {
+        size_t buffer_size;
+        size_t row_idx;
+    };
+
     struct JniContext {
         JavaFunctionCall* parent = nullptr;
 
         jobject executor = nullptr;
 
         int64_t input_values_buffer_ptr;
         int64_t input_nulls_buffer_ptr;
-        int64_t input_byte_offsets_ptr;
+        int64_t input_offsets_ptrs;

Review comment:
       maybe use unique_ptr to manage the mem is better, the int64_t only use 
in thrift struct




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to